jroesch commented on a change in pull request #7370:
URL: https://github.com/apache/tvm/pull/7370#discussion_r568157375
##########
File path: src/parser/tokenizer.h
##########
@@ -212,6 +212,25 @@ struct Tokenizer {
}
}
+ Token ParseNumber(bool is_pos) {
+ std::stringstream ss;
+ while (More() && IsNumeric(Peek())) {
Review comment:
This is like some of the oldest tokenizer code, and I was just quickly
trying to write one without getting super into regex, etc. Might be worth
completely replacing soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
