gromero edited a comment on pull request #7333: URL: https://github.com/apache/tvm/pull/7333#issuecomment-776294700
@areusch Hi Andrew. The change looks good (I'll differ the review of `Jenkinsfile` to others). I just suggest to fit docstrings of `get_standalone_crt_dir` and `get_standalone_crt_lib()` in 80 columns maximum. Also, a side note on the PR itself, if possible, I'd avoid merges in the middle of the incremental changes pushed to the branch to be reviewed, because it makes a tad difficult to squash the commits into the final change, in that sense I think rebasing on top of master is better. I tested `micro_tflite.py` against a disco board too and it's good. So, thumbs up from my side. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
