gromero commented on pull request #7333: URL: https://github.com/apache/tvm/pull/7333#issuecomment-776787476
> @gromero thanks for the review. unfortunately if you force-push (I.e. rebase) it loses the context around the previous comments, and I like that less :/. @areusch yeah.. I forgot about the "constraint" on push -f. Maybe the only thing we could do is to try to avoid merging in the middle of the incremental pushes (pushes due to the review process)? On the other hand that amounts to not doing a rebase on the top of the most fresh code in `main`, but I wonder if github and the CI is actually already covering what might go wrong if rebase is not done (github will check for merge conflicts on top of the `main` branch, but I'm not sure about the CI, I guess it only builds and tests the branch ones want to merge into `main`, i.e. it doesn't build the commits found in github's "Commits" tab on top of the `main` branch). Yep, tricky thing, merging in the middle of the incremental pushes for complicated changes might get really hard to review. I see. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
