leandron commented on a change in pull request #7462:
URL: https://github.com/apache/tvm/pull/7462#discussion_r578322231
##########
File path: include/tvm/target/target_kind.h
##########
@@ -376,7 +376,8 @@ inline TargetKindRegEntry& TargetKindRegEntry::set_name() {
.add_attr_option<String>("tag") \
.add_attr_option<String>("device") \
.add_attr_option<String>("model") \
- .add_attr_option<Array<String>>("libs")
+ .add_attr_option<Array<String>>("libs") \
+ .add_attr_option<Target>("host")
Review comment:
I'm just curious on how this plays with existing logic in `build()` at
`build_module.py`, which has a `target_host` parameter:
https://github.com/apache/tvm/blob/b7e0cfb6d469c3745ae2195908daadea9c64d87e/python/tvm/relay/build_module.py#L197
Does this mean we now have two ways of declaring `target_host`? If so, are
planning to deprecate one of them?
Also, in case the user declares both (_doesn't make much sense, but can be
done once this PR is meged_), which one takes precedece, or, should we show an
error? I'm referrin to something like `relay.build(target="cuda --host
nvidia/jetson-nano", target_host="llvm"...)`
cc @manupa-arm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
