junrushao1994 commented on a change in pull request #7462:
URL: https://github.com/apache/tvm/pull/7462#discussion_r578749624



##########
File path: python/tvm/target/target.py
##########
@@ -46,7 +46,7 @@ class Target(Object):
     - :py:func:`tvm.target.intel_graphics` create Intel Graphics target
     """
 
-    def __init__(self, tag_or_str_or_dict):
+    def __init__(self, tag_or_str_or_dict, host_tag_or_str_or_dict=None):

Review comment:
       In terms of sub-targets, I think it will be better to converge to 
composite targets instead, where we can specify a list of targets as 
`--devices`: 
https://github.com/apache/tvm/blob/main/src/target/target_kind.cc#L311-L313.
   
   We can help create a short cut to construct the composite kind, like adding 
a static function
   
   ```python
   @staticmethod
   def composite(target, devices):
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to