leandron commented on a change in pull request #7462:
URL: https://github.com/apache/tvm/pull/7462#discussion_r579047173
##########
File path: python/tvm/target/target.py
##########
@@ -46,7 +46,7 @@ class Target(Object):
- :py:func:`tvm.target.intel_graphics` create Intel Graphics target
"""
- def __init__(self, tag_or_str_or_dict):
+ def __init__(self, tag_or_str_or_dict, host_tag_or_str_or_dict=None):
Review comment:
> for the API, I would almost expect `Target(target_host, sub_target_0,
sub_target_1, ...)`
In terms of API, that would be very good indeed!
If internally we would convert that to represent the required `composite
target`, with specific dictionary representing all the internal data
structures, etc., that's implementation details the _we care about_, but the
end-user, interested in compiling a model shouldn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
