FrozenGene commented on pull request #7469:
URL: https://github.com/apache/tvm/pull/7469#issuecomment-783134102


   > Thanks @FrozenGene I wonder if we can also use an alternative method, e.g. 
add counter in the simplifiers recursive calls and throw an exception when a 
maximum iteration number is reached
   
   Thanks @tqchen 's good suggestion. If we do like this, how do we handle this 
exception? continue or abort or whatever. Another thing is how do we add the 
counter elegantly. When we recursive call in the rewrite simplifier, we in fact 
analyze the whole expr and then recusive calling VisitExpr. If we want to 
record cnt, must we add in the `class ExprFunctor`'s `VisitExpr`? I think it 
maybe not elegant enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to