leeexyz commented on pull request #7469: URL: https://github.com/apache/tvm/pull/7469#issuecomment-784678376
> > > > Hi, this is a good and simple idea to skip the expression too complex. I just wonder if there is a case that many basic arithmetic operations composited together, and many of them can be simplified. But, here using a counter to calculate the complexity of expression and skip it if greater than a const, say 256 in the PR. Is it appropriate? > > > > > > > > > Good question. Here assumes even we could simplify many basic arithmetic operations we still give up because it will cost hours+ to compile, compared with optimization, we choose to maintain users' experience. > > > > > > Thanks for the clarity, user experience is always the first choice. But, I think it does not consume much time compare to symbolic expressions which cannot be simplified at all (in your TFLite case). > > Ah...unfortunately, In fact, in my tflite case, our compile time almost costs on the `rewrite_simplify` and `canonical_simplify`. If you have interest, you could try to patch #7456, remove the expression complexity restrict and run TFLite mobilenet v2 qat model (in tests/python/frontend/tflite/test_forward.py). We maybe hang hours+ to complete compling... so indeed it consume much time to compile. Thanks :) Let me run it. I saw the issue in #7456 and found that the symbolic expressions are too complex to simplify. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
