tkonolige commented on pull request #7495: URL: https://github.com/apache/tvm/pull/7495#issuecomment-784326126
I tried the separate instruction approach. It works ok, but there are some challenges around the timing of Invoke and InvokeClosure. I ultimately dropped the separate instruction approach because if you want to profiling everything, you have to change all the instructions or insert a ton on profiling instructions. I think the approach in this PR is fine. However, I will point out that this PR does not time Invoke and InvokeClosure correctly. It just times how long it takes to start the function call, not the total time spent in the call. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
