monklof commented on a change in pull request #7495:
URL: https://github.com/apache/tvm/pull/7495#discussion_r582574176



##########
File path: include/tvm/runtime/vm/bytecode.h
##########
@@ -26,6 +26,7 @@
 
 #include <tvm/runtime/data_type.h>
 #include <tvm/support/logging.h>
+#include <string>

Review comment:
       I think it's just fine since the result of InstructionStrRepr() is not a 
part of runtime's state, it's just used for profiling,  and we don't need the 
object-system. I'm new to tvm, please correct me if my understanding to the 
object-system is wrong.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to