Hzfengsy commented on a change in pull request #7630:
URL: https://github.com/apache/tvm/pull/7630#discussion_r595309054
##########
File path: python/tvm/script/scope_handler.py
##########
@@ -16,32 +16,59 @@
# under the License.
"""TVM Script Parser Scope Handler Classes"""
# pylint: disable=redefined-builtin, unused-argument, invalid-name,
relative-beyond-top-level
+from typing import Tuple, Any, Callable, Optional, List, Union, Mapping
+import synr
from synr import ast
import tvm.tir
-from .utils import get_param_list, from_synr_span
+from tvm.runtime import Object
+from tvm.ir import Span, Range
+from tvm.tir import Stmt, PrimExpr, IterVar, Var, Buffer, BufferRegion, ForKind
+
+from .context_maintainer import ContextMaintainer
+from .utils import (
+ get_param_list,
+ tvm_span_from_synr,
+ buffer_slice_to_region,
+ call_with_error_reporting,
+)
from .registry import register
+from .node import BufferSlice
class ScopeHandler:
"""Base class for all scope handlers"""
- def __init__(self, func):
- self.func = func
- self.body = None
- self.node = None
- self.context = None
+ def __init__(self, func: Callable):
Review comment:
I think most of those are documented. Perhaps some simple class has no
parameters docs which is not necessary in my opinion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
