tkonolige edited a comment on pull request #7630:
URL: https://github.com/apache/tvm/pull/7630#issuecomment-802200082


   I'd like my latest round of reviews addressed. We need documentation in 
`context_maintainer.py` and `special_stmt.py` so that other developers can 
understand and work on this code. I agree that more user-focused documentation 
can go somewhere else, but the documentation for developers in these files 
needs to be improved.
   
   Is especially important that we document the difference in usage of 
`enter_scope` and `enter_block_scope` as we'll need these for any new 
constructs in the parser. High level documentation of the difference between a 
regular and block scope from the perspective of the parser is important.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to