jroesch commented on a change in pull request #7746:
URL: https://github.com/apache/tvm/pull/7746#discussion_r602613654
##########
File path: include/tvm/runtime/vm/executable.h
##########
@@ -125,9 +133,17 @@ class Executable : public ModuleNode {
* \brief Get the `lib` module in an executable. Users have the flexibility
to call
* `export_library` from the frontend to save the library to disk.
*
- * \return The runtime module that contains the hardwre dependent code.
+ * \return The runtime module that contains the hardware dependent code.
*/
- runtime::Module GetLib() const { return lib; }
+ runtime::Module GetLib() const { return this->imports_[0]; }
+
+ void SetLib(const runtime::Module& lib) {
Review comment:
I wrote this comment later in the code but we need to support partial
initialization for the serialization case, if we rework how Module
serialization works we could remove this but now I want to ensure we initialize
it correctly and also provide an interface so we don't have to rewrite all the
code if we iterate on this interface over the next few months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
