areusch commented on a change in pull request #7746:
URL: https://github.com/apache/tvm/pull/7746#discussion_r602627326
##########
File path: python/tvm/runtime/vm.py
##########
@@ -299,12 +300,16 @@ class VirtualMachine(object):
POOLED_ALLOCATOR = 2
def __init__(self, exe, device, memory_cfg=None):
Review comment:
can you do the last part here?
##########
File path: src/runtime/library_module.cc
##########
@@ -106,16 +106,16 @@ Module LoadModuleFromBinary(const std::string& type_key,
dmlc::Stream* stream) {
if (f == nullptr) {
std::string loaders = "";
for (auto name : Registry::ListNames()) {
- if (name.rfind(loadkey, 0) == 0) {
+ if (name.find(loadkey, 0) == 0) {
if (loaders.size() > 0) {
loaders += ", ";
}
loaders += name.substr(loadkey.size());
}
}
- ICHECK(f != nullptr) << "Binary was created using " << type_key
- << " but a loader of that name is not registered.
Available loaders are "
- << loaders << ". Perhaps you need to recompile with
this runtime enabled.";
+ LOG(FATAL) << "Binary was created using " << type_key
Review comment:
why LOG(FATAL)?
##########
File path: include/tvm/runtime/vm/executable.h
##########
@@ -125,9 +133,17 @@ class Executable : public ModuleNode {
* \brief Get the `lib` module in an executable. Users have the flexibility
to call
* `export_library` from the frontend to save the library to disk.
*
- * \return The runtime module that contains the hardwre dependent code.
+ * \return The runtime module that contains the hardware dependent code.
*/
- runtime::Module GetLib() const { return lib; }
+ runtime::Module GetLib() const { return this->imports_[0]; }
+
+ void SetLib(const runtime::Module& lib) {
Review comment:
isn't Import a public function, is what I'm saying? SetLib is
effectively an internal function used from import, correct?
##########
File path: src/relay/backend/vm/compiler.cc
##########
@@ -1155,18 +1155,20 @@ void VMCompiler::Codegen() {
auto compile_engine = CompileEngine::Global();
auto ext_mods = compile_engine->LowerExternalFunctions();
+ runtime::Module lib;
if (funcs.size() > 0) {
Map<String, IRModule> build_funcs;
for (const auto& i : funcs) {
build_funcs.Set(i.first, i.second);
}
- exec_->lib = tvm::build(build_funcs, target_host_);
+ lib = tvm::build(build_funcs, target_host_);
} else {
// There is no function handled by TVM. We create a virtual main module
// to make sure a DSO module will be also available.
- exec_->lib = codegen::CSourceModuleCreate(";", "", Array<String>{});
+ lib = codegen::CSourceModuleCreate(";", "", Array<String>{});
}
- exec_->lib = codegen::CreateMetadataModule(params_, exec_->lib, ext_mods,
target_host_);
+ lib = codegen::CreateMetadataModule(params_, lib, ext_mods, target_host_);
+ exec_->SetLib(lib);
Review comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
