comaniac commented on a change in pull request #7765: URL: https://github.com/apache/tvm/pull/7765#discussion_r604260468
########## File path: src/tir/schedule/utils.h ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#ifndef TVM_TIR_SCHEDULE_UTILS_H_ +#define TVM_TIR_SCHEDULE_UTILS_H_ + +#include <tvm/arith/analyzer.h> +#include <tvm/tir/analysis.h> +#include <tvm/tir/function.h> +#include <tvm/tir/op.h> +#include <tvm/tir/schedule/state.h> +#include <tvm/tir/stmt_functor.h> + +#include "./analysis.h" + +namespace tvm { +namespace tir { + +/*! + * \brief A helper macro to convert an sref to the statement it points to, + * then check if the downcasting succeeded. + * \param Result The result variable, used for checking + * \param SRef The SRef to be casted + * \param Type The type to be casted to, can be Block or For + * \note The `E` in the macro means `error`, which means allowing to customize error message + */ +#define TVM_SREF_TO_E(Result, SRef, Type) \ Review comment: The reasons you illustrated make sense to me, although I still don't like the coding style. It seems like extracting a common piese of _expression_ to be a macro. Anyways, as you mentioned, this macro is an internal utility which is more like just a helper, so I'm not strongly against it. For the naming, probably `TVM_SREF_AS_OR_ERR` would be more straightforward? "E" is not a proper and common abbrevation of "Error" so I don't think it is informative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
