junrushao1994 commented on pull request #7765: URL: https://github.com/apache/tvm/pull/7765#issuecomment-810576037
Per discussion with @tqchen. A1. I agree that enforcing name uniqueness in scheduling is important and it is something we should do. We also recognize the name uniqueness is a bit misleading and not super useful in subsequent IR passes. Therefore, we want to divide the problems in two steps: - Scheduling: Require name uniqueness - we can keep a table in the schedule class. - Passes after scheduling: Don't require name uniqueness. A2. Reserve names for the root block: Yes, we should do that. We have two proposals: - A2.1. Use "root" as the reserved name for the block - A2.2. Use the PrimFunc's name in the IRModule, e..g "main", as the reserved name for the block A3. Yes, we want to enable users who call scheduling primitives to specify the names of the blocks. Particularly, we want to hear some further discussions on the user experience should look like. Here is our proposal: - A3.1. Error out when user provide a duplicate name. - A3.2. If the name string the user provided is suffixed with "*", e.g. "unique_name*", then our system will find a unique name whose prefix is "unique_name" and doesn't conflict with other names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
