leandron commented on a change in pull request #7792:
URL: https://github.com/apache/tvm/pull/7792#discussion_r607965428
##########
File path: python/tvm/driver/tvmc/autotuner.py
##########
@@ -138,7 +138,11 @@ def add_tune_parser(subparsers):
"Autoscheduler options",
"Autoscheduler options, used when --enabled-auto-scheduler is
provided",
)
-
+ auto_scheduler_group = parser.add_argument(
+ "--enable-hardware-params",
+ help="enable hardware specific controls such as cores, threads, memory
etc.",
Review comment:
Can you mention what is the default?
##########
File path: python/tvm/driver/tvmc/autotuner.py
##########
@@ -286,17 +290,18 @@ def drive_tune(args):
)
if args.enable_autoscheduler:
- # Specify hardware parameters
- hardware_params = auto_scheduler.HardwareParams(
- args.num_cores,
- args.vector_unit_bytes,
- args.cache_line_bytes,
- args.max_shared_memory_per_block,
- args.max_local_memory_per_block,
- args.max_threads_per_block,
- args.max_vthread_extent,
- args.warp_size,
- )
+ if args.enable_hardware_params:
+ # Specify hardware parameters
+ hardware_params = auto_scheduler.HardwareParams(
Review comment:
What is the value for `hardware_params`, used in line 310 below, in case
`args.enable_hardware_params` is `False`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
