comaniac commented on a change in pull request #7792:
URL: https://github.com/apache/tvm/pull/7792#discussion_r608156141
##########
File path: python/tvm/driver/tvmc/autotuner.py
##########
@@ -138,7 +138,11 @@ def add_tune_parser(subparsers):
"Autoscheduler options",
"Autoscheduler options, used when --enabled-auto-scheduler is
provided",
)
-
+ auto_scheduler_group = parser.add_argument(
+ "--enable-hardware-params",
+ help="enable hardware specific controls such as cores, threads, memory
etc.",
Review comment:
That makes a lot sense. However, IMHO, this still confuses people,
unless you could make those commandline arguments visible only when
`--enable-hardware-params` is specified (like put them to a subparser), so that
people won't see those arguments when `tvmc ... -h` but can only see them with
`tvmc ... --enable-hardware-params -h`. Otherwise I could imagine an advance
user specifies `--num-cores` but feels weird about why it isn't effective, and
finally finds that `--enable-hardware-params` is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
