giuseros commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r610707236
########## File path: include/tvm/runtime/crt/aot/tvm_executor.h ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file include/tvm/runtime/crt/aot/tvm_executor.h + * \brief TVM Executor for the Ahead-of-Time Runtime + * + * AOT models are described by the TVM model descriptor format + * which can be passed to tvm_runtime_run. These descriptors will be + * generated by the AOT compilation process. This can optionally be + * augmented with platform specific context to be passed to the TVM + * operators. + * + * Example: Review comment: So, I am not sure that coming up with a common graph_executor/aot_executor API is beneficial here. In aot the interface is very tiny, in theory it might even be unnecessary. The graph executor presents the burden of parsing the json etc... so it would require a more sophisticated interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
