giuseros commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r611842671
########## File path: src/runtime/crt/common/aot_backend_api.c ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +// LINT_C_FILE + +#include <assert.h> +#include <inttypes.h> +#include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include <tvm/runtime/c_backend_api.h> +#include <tvm/runtime/crt/error_codes.h> +#include <tvm/runtime/crt/logging.h> +#include <tvm/runtime/crt/platform.h> + +#include "crt_config.h" + +void* TVMBackendAllocWorkspace(int device_type, int device_id, uint64_t nbytes, int dtype_code_hint, Review comment: My main issue is about `TVMBackendRegisterSystemLibSymbol`. This is a `TVMBackend` API, and I feel it should stay in crt_backend. The point is that aot backend and crt backend are different, and that's why I created this file. Are you proposing to put `TVMBackendRegisterSystemLibSymbol` somewhere in `crt/runtime`? Anyway, this seems a minor point. Let's agree on a proposal that avoid the platform to define a fake `TVMBackendRegisterSystemLibSymbol` since this won't be used by AOT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
