tqchen commented on a change in pull request #7785:
URL: https://github.com/apache/tvm/pull/7785#discussion_r611876257
##########
File path: src/target/source/codegen_c_host.cc
##########
@@ -40,13 +40,16 @@ namespace codegen {
CodeGenCHost::CodeGenCHost() { module_name_ =
GetUniqueName("__tvm_module_ctx"); }
-void CodeGenCHost::Init(bool output_ssa, bool emit_asserts, std::string
target_str) {
+void CodeGenCHost::Init(bool output_ssa, bool emit_asserts, bool
is_aot_executor,
+ std::string target_str) {
Review comment:
Expanding further, we have made a set of assumptions of the availability
of tvm's runtime API. On the default land that contract is
runtime/c_runtime_api and runtime/c_backend_api, both of which are clearly
documented.
Given the potential need to have a different path on the embedded setting(to
avoid string lookup and use symbol), we should clarify and document what is the
CRT standard so that the new code generator can refer to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
