junrushao1994 commented on pull request #7809: URL: https://github.com/apache/tvm/pull/7809#issuecomment-819034462
Thanks for the contribution! A few high-level comments: 1. Do not add any C API - we can use packed func to expose the interface. Op is a compile-time concept so please move the registration logic out of the runtime :-) 2. Please change `register_op` to some name like `register_intrin_lowering`, and consider accept a target kind like `default`/`llvm`/`cuda` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
