zxybazh commented on a change in pull request #7809:
URL: https://github.com/apache/tvm/pull/7809#discussion_r616227265
##########
File path: src/target/intrin_rule.cc
##########
@@ -24,179 +24,234 @@
#include "intrin_rule.h"
#include <tvm/tir/op.h>
+#include <tvm/tir/op_attr_types.h>
namespace tvm {
namespace codegen {
namespace intrin {
+using tir::FLowerIntrinsic;
-TVM_REGISTER_GLOBAL("tvm.intrin.rule.default.exp").set_body(DispatchPureExtern<FloatSuffix>);
+TVM_REGISTER_OP("tir.exp").set_attr<FLowerIntrinsic>("default.FLowerIntrinsic",
Review comment:
I think the naming is just fine because the `lower_intrinsic.cc`file
kind of implies it's default rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
