giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-822853857
Hi @manupa-arm , @areusch , I applied most of the changes. Namely: * Moved to a `call_cpacked` builtin * Moved the `aot_executor.h` in internal * Moved to use `tir::Allocate` * Removed the `aot_backend_api.c` (and defined a fake `TVMFuncRegisterGlobal` in `test.c`) * Removed the runner function `PrimFunc` returned as internal representation by AOT I partially addressed the following: * About unification of `BuildOutput` , @manupa-arm we agreed that it is too complex to do now, because of the `get_graph_json` method defined in the `RelayBuildModule`. * Instead of passing the `LoweredOutput` to the `CreateMetadataModule` I moved `AOTMetadata` to a generic `Metadata` and used it. The main reason is that otherwise I need to expose to the Object system the `LoweredOutput` class, which seems to be too much of an internal back-end class to be exposed. Please, let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
