giuseros commented on pull request #7785:
URL: https://github.com/apache/tvm/pull/7785#issuecomment-825603629
Hi @areusch ,
I worked on your suggestions, this is what I did:
* Moved meta_data.h in include/tvm/runtime. This is to use the
runtime::kTvmExecutor{Graph,Aot} also from tests, and in this way we don't need
to `include` relative paths in the files.
* Added the stack FIFO memory checks. We are "wasting" 4 bytes per block, so
I enabled it only if `TVM_CRT_RUNTIME` is defined.
* In the Executor factory, I merged `get_internal_repr` and
`save_executor_config` in a single `get_executor_config`
* Added tests for the content of sid sizes.
Only thing I wasn't able to do was to add tests for FIFO enforcement. I have
a test working in my local repo, but the problem is that I am not able to
define `TVM_CRT_RUNTIME` for the single `aot_memory_test.cc` (the best would be
to define it for the single test). Any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
