giuseros commented on a change in pull request #7785:
URL: https://github.com/apache/tvm/pull/7785#discussion_r620580137
##########
File path: src/target/source/codegen_source_base.h
##########
@@ -155,7 +156,8 @@ runtime::Module CSourceModuleCreate(const String& code,
const String& fmt,
*/
runtime::Module CreateMetadataModule(
const std::unordered_map<std::string, runtime::NDArray>& params,
runtime::Module target_module,
- const Array<runtime::Module>& ext_modules, Target target);
+ const Array<runtime::Module>& ext_modules, Target target,
Review comment:
The reason why I gave it a default was that it's also invoked from
`compiler.cc` for the vm executor. I can change `compiler.cc` to pass the
default or leave the the default in the header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
