mherkazandjian commented on a change in pull request #7917:
URL: https://github.com/apache/tvm/pull/7917#discussion_r621038916
##########
File path: cmake/libs/Libbacktrace.cmake
##########
@@ -21,7 +21,16 @@ ExternalProject_Add(project_libbacktrace
SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}/../../3rdparty/libbacktrace
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/libbacktrace
CONFIGURE_COMMAND
"${CMAKE_CURRENT_LIST_DIR}/../../3rdparty/libbacktrace/configure"
- "--prefix=${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
--with-pic
+ "--prefix=${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
+ --with-pic
+ "CC=${CMAKE_C_COMPILER}"
+ "CFLAGS=${CMAKE_C_FLAGS}"
+ "LDFLAGS=${CMAKE_EXE_LINKER_FLAGS}"
+ "CPP=${CMAKE_C_COMPILER} -E"
Review comment:
i looked into the github repo of
[libbacktrace](https://github.com/ianlancetaylor/libbacktrace) and it seems
here ``CPP``
refers to the C preprocess (not C++), so it think it is correct to keep it
as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
