mherkazandjian commented on a change in pull request #7917:
URL: https://github.com/apache/tvm/pull/7917#discussion_r621070046
##########
File path: cmake/libs/Libbacktrace.cmake
##########
@@ -21,7 +21,16 @@ ExternalProject_Add(project_libbacktrace
SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}/../../3rdparty/libbacktrace
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/libbacktrace
CONFIGURE_COMMAND
"${CMAKE_CURRENT_LIST_DIR}/../../3rdparty/libbacktrace/configure"
- "--prefix=${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
--with-pic
+ "--prefix=${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
+ --with-pic
+ "CC=${CMAKE_C_COMPILER}"
+ "CFLAGS=${CMAKE_C_FLAGS}"
+ "LDFLAGS=${CMAKE_EXE_LINKER_FLAGS}"
+ "CPP=${CMAKE_C_COMPILER} -E"
+ "NM=${CMAKE_NM}"
+ "STRIP=${CMAKE_STRIP}"
+ "CPPFLAGS=${CMAKE_C_FLAGS}"
+ "--host=${MACHINE_NAME}"
Review comment:
actually i am not sure is ``-DCMAKE_HOST`` is neccessary, but it does
not hurt (i guess)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
