mherkazandjian commented on pull request #7917:
URL: https://github.com/apache/tvm/pull/7917#issuecomment-828872802
> @mherkazandjian We should not require `MACHINE_NAME` be passed in as part
of the build. The cmake script should check if it is set and then add the
correct configure flags.
@tkonolige i fixed the issue with the CI, the
``CPPFLAGS=${CMAKE_CXX_FLAGS}`` was the cause, I removed it since
``g++`` is not used/needed for libbacktrace (it is written in C).
the macOS build seems to be passing
following up on your comment
https://github.com/apache/tvm/pull/7917#issuecomment-828562180
you mean including the snippet below in ``Libbacktrace.cmake`` (although )
fixes the issue for macOS? what did you mean
by "although not correct?"
i do not have access to a mac.
````cmake
if(CMAKE_SYSTEM_NAME MATCHES "Darwin" AND (CMAKE_C_COMPILER MATCHES
"^/Library"
OR CMAKE_C_COMPILER MATCHES "^/Applications"))
set(c_compiler "/usr/bin/cc")
else()
set(c_compiler "${CMAKE_C_COMPILER}")
endif()
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
