rijulg opened a new pull request #8006:
URL: https://github.com/apache/tvm/pull/8006


   At the moment compiling this file throws multiple errors with C++ compilers, 
this change proposes to fix them.
   1. `tvm_model_t->run_func` of type `TVMBackedPackedFunc` returns an int at 
the moment which is different from the signature of this function 
`tvm_runtime_run`, implicit casting is not favorable in many compile chains and 
throws errors.
   2. The index of iterators were of type `int` while that of 
`model->num_input_tensors` and `model->num_output_tensors` were of type 
`uint32_t`, this type difference again throws errors in many toolchains, and 
can potentially cause incorrect calculations.
   3. C Style struct initialization of tensors with `(DLTensor){...}` is not 
supported in many C++ toolchains and throws “non-trivial designated 
initializers not supported” error. Explicitly setting values should work in all 
cases even though it looks a little less nice.
   
   Thanks for contributing to TVM!   Please refer to guideline 
https://tvm.apache.org/docs/contribute/ for useful information and tips. After 
the pull request is submitted, please request code reviews from 
[Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers)
 by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to