jcf94 commented on pull request #8006: URL: https://github.com/apache/tvm/pull/8006#issuecomment-835134183
> > Looks like this is a `.c` file, and I'm guessing is this designed to be compiled by a C compiler? > > Yes, it is probably designed to be compiled with a C compiler, but problems 1 and 2 should be encountered with any compilation process that prohibits implicit typecasting. Additionally the file can readily be used with C++ compiler, so it might be worth changing the structure initialisation to work with C++ compilers. Yeah, I agree. Besides, we should better use `size_t` instead of the `uint32_t`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
