giuseros commented on a change in pull request #8014:
URL: https://github.com/apache/tvm/pull/8014#discussion_r630166332
##########
File path: python/tvm/micro/model_library_format.py
##########
@@ -55,17 +55,19 @@ def _populate_codegen_dir(mod, codegen_dir: str):
mod_indices = {"lib": 0, "src": 0}
host_codegen_dir = os.path.join(codegen_dir, "host")
+ lib_name = f"{model_name}_lib" if model_name else "lib"
Review comment:
The idea here is that if we can specify the name also for the files, I
can have those files into the same folder. This makes testing (and hence
deployment) way, way easier. About the naming, let's discuss it on the RFC. I
don't have any strong opinion, but the idea here was that if we do
`{model_name}_function` for the operators we can also do `{model_name}_lib.c`
for the file names. If we decide to put `_tvm_ as a constant prefix, then let's
put it also in front of the file names (without the `_`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
