giuseros commented on a change in pull request #8014:
URL: https://github.com/apache/tvm/pull/8014#discussion_r631677060
##########
File path: python/tvm/relay/build_module.py
##########
@@ -115,6 +117,9 @@ def build(self, mod, target=None, target_host=None,
params=None, executor="graph
- If "graph" is specified, then the graph_executor will be used
- If "aot" is specified, then the aot_executor will be used
+ mod_name: Optional[str]
+ The module name we will build
Review comment:
I didn't think about any restrictions. The idea was to use the name
provided by the user as it is. You are asking something like : `verify("&%!")
== false`? If yes, two points:
1. I would only validate. If the name is not valid, an error should be thrown
2. Any suggestions on what makes a "valid" name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
