tqchen commented on pull request #7952: URL: https://github.com/apache/tvm/pull/7952#issuecomment-844349244
given there is a precedence of API, (LLVM/MLIR) that fuses runBefore and shouldRun. I actually agree with @zackcquic that we should follow the previous API precedence so we get better consistency per https://tvm.apache.org/docs/contribute/code_review.html?highlight=review#deliberate-on-api-and-data-structures "Be consistent with existing well-known package’s APIs if the features overlap." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
