Lunderberg commented on pull request #8127: URL: https://github.com/apache/tvm/pull/8127#issuecomment-848383793
Definitely agreed, `vulkan.cc` could do with a bit of splitting for readability at this point. I was also thinking that the `VulkanContext` would be good to split out into a separate file, and could have the device-specific initialization logic moved to it. This PR pushes the `VulkanDeviceAPI` constructor to nearly 300 lines, which is a bit difficult for me to follow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
