Lunderberg commented on pull request #8127: URL: https://github.com/apache/tvm/pull/8127#issuecomment-848902009
> @Lunderberg Very nice! As a follow up, I think we should > > * Add warp sync to fix reduction, use subgroup barrier if vulkan 1.1 is available (and update the validator) > > * Use a target specific max push constant bytes instead of hard coded value Thank you, and agreed! I've been making mental notes on other items that we can check or conditionally include, which will probably go in after the refactoring. * Pass boolean arrays in using smallest available integer type, instead of only 8-bit int. * Verify maximum UBO size (unlikely that we'll even get close to the spec-guaranteed size of 16k, but worth checking) * For loop indices, use largest available integer type, instead of only 64-bit int. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
