Mousius commented on a change in pull request #8023:
URL: https://github.com/apache/tvm/pull/8023#discussion_r643849058



##########
File path: include/tvm/runtime/module.h
##########
@@ -232,6 +232,8 @@ constexpr const char* tvm_param_prefix = "__tvm_param__";
 constexpr const char* tvm_lookup_linked_param = "_lookup_linked_param";
 /*! \brief The main AOT executor function */
 constexpr const char* tvm_run_func_prefix = "tvm__run_func";
+/*! \brief The entrypoint function to the generated network */

Review comment:
       In this PR we're generating a packed function to wrap the AOT executor 
function, would it be worth emitting `tvm_module_main` rather than creating a 
new `tvm_entrypoint_name` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to