areusch commented on a change in pull request #8023:
URL: https://github.com/apache/tvm/pull/8023#discussion_r644073943
##########
File path: include/tvm/runtime/module.h
##########
@@ -232,6 +232,8 @@ constexpr const char* tvm_param_prefix = "__tvm_param__";
constexpr const char* tvm_lookup_linked_param = "_lookup_linked_param";
/*! \brief The main AOT executor function */
constexpr const char* tvm_run_func_prefix = "tvm__run_func";
+/*! \brief The entrypoint function to the generated network */
Review comment:
hrm couple thoughts:
- `tvm_module_main` is supposed to be the default name of a function
contained within a runtime.Module. It tends to be used with autotuning--the
lone function being tuned is named `tvm_module_main`. I believe it's also used
when Relay isn't used to build a model-level thing.
- It's been called the "entrypoint" before, so it does seem like it would
match
- At minimum we'd need to ensure it becomes eventually prefixed to the
module. I think that's being done in https://github.com/apache/tvm/pull/8014.
- However, there is a thought from [Model-based Module Runtime
Interface](https://discuss.tvm.apache.org/t/discuss-module-based-model-runtime-interface/5025)
that the entrypoint should be the name of the model (as passed to
tvm.relay.build). I don't know that anyone's made good on that yet, but that
would be the most future-proof thing, I think (or at least, it would be most
aligned with the forum).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
