mshawcroft commented on a change in pull request #8382: URL: https://github.com/apache/tvm/pull/8382#discussion_r663219991
########## File path: .pre-commit-config.yaml ########## @@ -0,0 +1,40 @@ +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v2.5.0 + hooks: + - id: check-added-large-files + - id: check-merge-conflict + - id: check-yaml + - id: end-of-file-fixer + - repo: local + hooks: + - id: run-file-types + name: Checking File Types... + entry: python3 tests/lint/check_file_type.py + language: system + always_run: true + pass_filenames: false + - id: run-headers-check + name: Checking ASF License Headers... + entry: tests/lint/check_asf_header.sh --local + language: system + always_run: true + pass_filenames: false + - id: run-black Review comment: @areusch there should be no need to provide additional constraints on their individual dependencies, if there is, that suggests an upstream bug w.r.t install_requires, are you aware of a specific issue or just concerned that there might be an issue? I'd expect that having pre-commit specify the top level version for each lint tool is sufficient that is the normal way to use pre-commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
