masahi commented on a change in pull request #8466:
URL: https://github.com/apache/tvm/pull/8466#discussion_r669976240
##########
File path: src/runtime/thread_storage_scope.h
##########
@@ -42,21 +42,23 @@ enum class StorageRank {
kGlobal = 0,
/*! \brief shared memory among thread group */
kShared = 1,
+ /*! \brief dynamic shared memory among thread group */
+ kDynShared = 2,
/*!
* \brief reserved for warp memory.
* This is only used by programming model.
* There is no such memory usually in GPU.
* Instead, we can simulate it by registers and shuffle.
*/
- kWarp = 2,
+ kWarp = 3,
Review comment:
Should be no problem, as long as nobody depends on the integer value.
All tests passed, so I assume it is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
