tqchen commented on a change in pull request #8466:
URL: https://github.com/apache/tvm/pull/8466#discussion_r671191780



##########
File path: src/runtime/thread_storage_scope.h
##########
@@ -96,6 +98,8 @@ struct StorageScope {
         return "global" + tag;
       case StorageRank::kShared:
         return "shared" + tag;
+      case StorageRank::kDynShared:

Review comment:
       Let us use the same storage scope, but introduce a different tag. e.g. 
shared.dyn

##########
File path: src/runtime/thread_storage_scope.h
##########
@@ -96,6 +98,8 @@ struct StorageScope {
         return "global" + tag;
       case StorageRank::kShared:
         return "shared" + tag;
+      case StorageRank::kDynShared:

Review comment:
       Let us use the same storage scope as shared, but introduce a different 
tag. e.g. shared.dyn




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to