masahi commented on a change in pull request #8443:
URL: https://github.com/apache/tvm/pull/8443#discussion_r670314255
##########
File path: include/tvm/relay/attrs/nn.h
##########
@@ -1463,6 +1463,21 @@ struct NLLLossAttrs : public
tvm::AttrsNode<NLLLossAttrs> {
}
}; // struct NLLLossAttrs
+/*! \brief Attributes used in Im2col operator */
+struct Im2colAttrs : public tvm::AttrsNode<Im2colAttrs> {
+ Array<IndexExpr> kernel_size;
+ Array<IndexExpr> dilation;
+ Array<IndexExpr> padding;
+ Array<IndexExpr> stride;
Review comment:
IndexExpr should be `Integer`. If you make this change you can remove
all the casts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
