mbrookhart commented on a change in pull request #8522:
URL: https://github.com/apache/tvm/pull/8522#discussion_r674240277
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -2099,6 +2099,14 @@ def expand_shape(in_shape, shape):
new_shape = _op.maximum(in_shape, shape)
Review comment:
I wonder if it would do the same thing to add fold_constant here? I
don't love the use of params, but I'm not strictly opposed to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
