JoeyChou-SiMa-ai commented on a change in pull request #8522:
URL: https://github.com/apache/tvm/pull/8522#discussion_r674426002



##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -2099,6 +2099,14 @@ def expand_shape(in_shape, shape):
             new_shape = _op.maximum(in_shape, shape)

Review comment:
       I agree that (1) not using the param and (2) using `dynamic_to_static` 
are the right solution here. I was simply thinking about getting all static 
operators from this frozen model but the concept is not correct here. 
   
   I will decline this PR. Thank you for the feedback.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to