zxybazh commented on pull request #8587:
URL: https://github.com/apache/tvm/pull/8587#issuecomment-889355628


   Thanks for the contribution!
   
   Json-style target string parsing is supported as the canonical way for 
target creation and json export is supported using the `export` function 
(though right now the export result is not pure json, it's actually a tvm Map 
object). In the long term, I am in favor of using json exclusively for `target 
-> str` conversion.
   
   Meanwhile, IIRC we are using the current `str` function (`target->str`) for 
compatibility with AutoTVM and Ansor (AutoScheduling). IMHO, If we want to 
extend the argument parsing to escape strings, I would suggest that we keep the 
`str` function the same, and work on parsing and `export` function first (with 
compatibility for `str` function output). Other than that, I'm not aware of any 
other potential breakage. I think Junru might add to that.
   
   cc @junrushao1994 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to