Lunderberg commented on a change in pull request #8587:
URL: https://github.com/apache/tvm/pull/8587#discussion_r680022546
##########
File path: tests/python/unittest/test_target_target.py
##########
@@ -76,6 +76,14 @@ def test_target_string_parse():
assert tvm.target.arm_cpu().device_name == "arm_cpu"
+def test_target_string_with_spaces():
+ target = tvm.target.Target(
+ "vulkan -device_name=Name\ of\ GPU\ with\ spaces -device_type=discrete"
Review comment:
I'd be down for either, and agree that the nested quotes are an easier
way to read it. Consistency with how tvmc handles spaces is also something
that I want to maintain, so I'll update this PR to use the same convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
