trevor-m commented on a change in pull request #8607:
URL: https://github.com/apache/tvm/pull/8607#discussion_r680147863
##########
File path: src/runtime/contrib/tensorrt/tensorrt_logger.h
##########
@@ -39,7 +39,7 @@ class TensorRTLogger : public nvinfer1::ILogger {
public:
TensorRTLogger() : TensorRTLogger(Severity::kWARNING) {}
explicit TensorRTLogger(Severity severity) : reportable_severity(severity) {}
- void log(Severity severity, const char* msg) override {
+ void log(Severity severity, const char* msg) noexcept override {
Review comment:
Is this change required to build against TRT 8? Could you check we can
still compile against earlier TRT versions such as 7 even with this change? If
we can't, then we should add `#if` around it.
##########
File path: tests/python/contrib/test_tensorrt.py
##########
@@ -474,14 +474,22 @@ def get_graph(x_shape=(1, 16), k_shape=(32, 16)):
def test_batch_matmul():
- def get_graph(x_shape=(12, 128, 64), y_shape=(12, 128, 64)):
+ def get_graph(x_shape=(12, 128, 64), y_shape=(12, 64, 128), transa=False,
transb=True):
x = relay.var("x", shape=(x_shape), dtype="float32")
y = relay.var("y", shape=(y_shape), dtype="float32")
- out = relay.nn.batch_matmul(x, y)
+ out = relay.nn.batch_matmul(
+ relay.transpose(x, [0, 2, 1]) if transa else x,
Review comment:
I don't think you need these `relay.transpose` on the inputs to test
functionality of transa/transb args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
