ymwangg commented on a change in pull request #8607:
URL: https://github.com/apache/tvm/pull/8607#discussion_r680189423
##########
File path: src/runtime/contrib/tensorrt/tensorrt_logger.h
##########
@@ -39,7 +39,7 @@ class TensorRTLogger : public nvinfer1::ILogger {
public:
TensorRTLogger() : TensorRTLogger(Severity::kWARNING) {}
explicit TensorRTLogger(Severity severity) : reportable_severity(severity) {}
- void log(Severity severity, const char* msg) override {
+ void log(Severity severity, const char* msg) noexcept override {
Review comment:
Yes, this is required for TRT8. I've tested TRT7 and it works. In TRT 8
the signature changes to`virtual void log(Severity severity, AsciiChar const*
msg) noexcept = 0;` from `virtual void log(Severity severity, const char* msg)
TRTNOEXCEPT = 0;` in TRT7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
