jroesch commented on a change in pull request #8597:
URL: https://github.com/apache/tvm/pull/8597#discussion_r684524153
##########
File path: src/relay/backend/interpreter.cc
##########
@@ -39,9 +42,81 @@
namespace tvm {
namespace relay {
-using namespace runtime;
+using runtime::ADT;
+using runtime::ADTObj;
+using runtime::NDArray;
+using runtime::TVMArgsSetter;
+using runtime::operator<<;
+
+namespace {
+// TODO(mbs): Centralize.
+struct PairHash {
+ template <typename T1, typename T2>
+ std::size_t operator()(const std::pair<T1, T2>& k) const {
+ return std::hash<T1>()(k.first) ^ std::hash<T2>()(k.second);
+ }
+};
+
+// Analogue of FlattenTupleType for runtime ADT vs NDArray values.
+// TODO(mbs): Hoist somewhere sensible, maybe op/memory.h?
+void FlattenADTAux(const ObjectRef& object_ref, std::vector<NDArray>* out) {
Review comment:
Yeah can we maybe just add an issue to unify these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
