gromero opened a new pull request #8739: URL: https://github.com/apache/tvm/pull/8739
Currently base-box-tool 'test' command will skip destroying the test VM if a single provider is specified (i.e. --provider virtualbox) even if all release tests pass. This is confusing (no warning is displayed to the user) and that will leave host resources (like USB devices necessary to run the test) locked by the VM. So if the user tries to use the same USB device the program using the device (e.g. openocd) will cryptically fail. Moreoever, even if all tests pass and more than one provider is specified but the option '--skip-build' is set a VM will be left running without notice. This commit changes that behavior by: 1. Always destroying the VM if the release test pass 2. Always keeping the VM up and running if a test fails 1. guarantees no resource remains locked by the VM without necessity. A new flag '--skip-destroy' is introduced in case the user still wants to keep a VM up and running if the release test pass. 2. guarantees the VM where the test failed is left running for further inspection of the test that failed. Finally, for both 1. and 2. cases a proper message is displayed to the user to inform if a VM was left running or not and about what actions the user can take next accordingly to the test result in the VM. Signed-off-by: Gustavo Romero <[email protected]> Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
